BUG: fix reference counting error in wrapping_method_resolve_descriptors#26190
Merged
charris merged 1 commit intonumpy:mainfrom Apr 1, 2024
Merged
BUG: fix reference counting error in wrapping_method_resolve_descriptors#26190charris merged 1 commit intonumpy:mainfrom
charris merged 1 commit intonumpy:mainfrom
Conversation
Member
Author
|
The nogil build stores the reference counts in a different spot in the |
Member
|
Thanks Nathan. |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like this copy/paste error has been here for two years!
This was found in the nogil python build, which may find other reference counting bugs that a more forgiving GIL implementation wasn't bothered by.