BUG: Ensure non-array logspace base does not influence dtype of output.#25919
Merged
rgommers merged 1 commit intonumpy:mainfrom Mar 4, 2024
Merged
BUG: Ensure non-array logspace base does not influence dtype of output.#25919rgommers merged 1 commit intonumpy:mainfrom
rgommers merged 1 commit intonumpy:mainfrom
Conversation
This was referenced Mar 3, 2024
Member
|
Thanks @mhvk! The CircleCI failure is related: |
9d99f6e to
136b9ed
Compare
Contributor
Author
|
OK, hopefully fixed now... |
Contributor
Author
|
The freebsd failure is unrelated, so this should be all OK now. |
Member
|
Thanks, it's not actually quite right, because we are not dealing with the other arguments being scalars. But at least it fixes the bigger problem. |
Contributor
Author
|
@seberg - ah, yes, I thought about doing it after the |
Member
|
Yeah, array-converter should help a bit, but it simply is tedious. The reason is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-24957