API: Create PyArray_DescrProto for legacy descriptor registration#25792
API: Create PyArray_DescrProto for legacy descriptor registration#25792seberg merged 1 commit intonumpy:mainfrom
PyArray_DescrProto for legacy descriptor registration#25792Conversation
PyArray_DescrProto for legacy descriptor registrationPyArray_DescrProto for legacy descriptor registration
ngoldbaum
left a comment
There was a problem hiding this comment.
Code changes look fine to me. Ping @WarrenWeckesser too for the perspective of a person maintaining some legacy dtypes.
We don't need to actually write new docs now, but we should either delete https://numpy.org/doc/stable/user/c-info.beyond-basics.html#user-defined-data-types or add a big warning over it saying it's a legacy API.
|
Also @jakevdp, I would like to push this through very soon, though. Without this there is absolutely no way we might make |
|
Rebased and added the alias also to the compat header. I will merge this once tests pass since Nathan said it looks good and it is just a bit nicer to work off main. |
First step, force users of registered dtypes to slightly change their code in order to free up changing our
descrstruct.