MAINT,API: Always export static inline version of array accessor.#25789
Merged
mattip merged 2 commits intonumpy:mainfrom Feb 8, 2024
Merged
MAINT,API: Always export static inline version of array accessor.#25789mattip merged 2 commits intonumpy:mainfrom
mattip merged 2 commits intonumpy:mainfrom
Conversation
While we might not hide the struct fully by default, I don't think there is a reason to not only export the static inline versions of these? They will type check a bit nicer (might give warnings), but otherwise should only matter if you do `PyArray_NDIM(arr) = 3`.
Mousius
approved these changes
Feb 8, 2024
Member
Mousius
left a comment
There was a problem hiding this comment.
Not entirely sure on the history here but this seems to be straightforward to me as well.
mattip
approved these changes
Feb 8, 2024
Member
mattip
left a comment
There was a problem hiding this comment.
LGTM. One doc nit to make the intention clearer.
[skip cirrus] [skip azp] [skip actions] Co-authored-by: Matti Picus <matti.picus@gmail.com>
Member
|
Thanks @seberg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we might not hide the struct fully by default, I don't think there is a reason to not only export the static inline versions of these?
They will type check a bit nicer (might give warnings), but otherwise should only matter if you do
PyArray_NDIM(arr) = 3.Or am I missing a reason to even have this? Seems like a relatively mild and good API change to only use the static-inline versions.