DEP: Finalize future warning move in lstsq default#25721
Merged
charris merged 1 commit intonumpy:mainfrom Jan 29, 2024
Merged
Conversation
charris
reviewed
Jan 29, 2024
| ``np.linalg.lstsq`` now defaults to new ``rcond`` value | ||
| ------------------------------------------------------- | ||
| `~numpy.linalg.lstsq` now uses the new rcond value of the machine precision | ||
| times ``max(M, N)``. Previously, the machine precision was used by a |
Member
Author
There was a problem hiding this comment.
The by was supposed to be a but, I think it's fine then? (sorry force pushed those two changes)
charris
reviewed
Jan 29, 2024
numpy/linalg/_linalg.py
Outdated
| to keep using the old behavior, use ``rcond=-1``. | ||
| .. versionchanged:: 2.0 | ||
| Previously, the default was ``-1``, but a warning was given that | ||
| this will change. |
NumPy 2.0 is clearly the (long overdue) time to do this...
Member
|
Thanks Sebastian. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumPy 2.0 is clearly the (long overdue) time to do this...
Closes gh-11015