BLD: fix building for windows ARM64#25613
Merged
seberg merged 1 commit intonumpy:mainfrom Jan 18, 2024
Merged
Conversation
Member
Author
|
also thanks @mattip for the very helpful pointer to where to look in the codebase |
Member
|
The check looks right, and if it compiles for you, then I think it should go in. Thanks Nathan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25604
With this change I can build numpy on my windows VM without disabling CPU detection.
It would probably be good to set up a windows ARM CI job but I'd rather not do that right now.