BUG: Fix regression with f2py wrappers when modules and subroutines are present#25361
Merged
charris merged 2 commits intonumpy:mainfrom Dec 10, 2023
Merged
BUG: Fix regression with f2py wrappers when modules and subroutines are present#25361charris merged 2 commits intonumpy:mainfrom
f2py wrappers when modules and subroutines are present#25361charris merged 2 commits intonumpy:mainfrom
Conversation
Co-authored-by: andrea-bia <andrea-bia@users.noreply.github.com>
Member
|
Thanks Rohit. The use of GitHub issues as names is convenient, but isn't informative for someone browsing the code. I think a longer descriptive name would be better, you only need to write it twice. |
f2py wrappers when modules and subroutines are presentf2py wrappers when modules and subroutines are present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25337. A two word fix, the problem was that if a module has functions (is not an only variable module) it shouldn't be skipped.
Thanks for the report @andrea-bia.