BUG: Fix moving compiled executable to root with f2py -c on Windows#25218
Merged
charris merged 1 commit intonumpy:maintenance/1.26.xfrom Nov 21, 2023
Merged
BUG: Fix moving compiled executable to root with f2py -c on Windows#25218charris merged 1 commit intonumpy:maintenance/1.26.xfrom
charris merged 1 commit intonumpy:maintenance/1.26.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #25160.
This is a follow up to #25000 (bug report) and #25073 (PR) which fixed f2py compilation under Windows using
f2py -cby declaringquadmathas dependency and referring to compatible Windows toolchains in the documentation.The f2py compile still does not work as expected under Windows as the compiled binary is not moved to the root directory after compile. This PR fixes that by searching for
*.pydfiles in addition to*.sofiles in the build directory.FORMAT IT RIGHT:
https://www.numpy.org/devdocs/dev/development_workflow.html#writing-the-commit-message
IF IT'S A NEW FEATURE OR API CHANGE, TEST THE WATERS:
https://www.numpy.org/devdocs/dev/development_workflow.html#get-the-mailing-list-s-opinion
HIT ALL THE GUIDELINES:
https://numpy.org/devdocs/dev/index.html#guidelines
WHAT TO DO IF WE HAVEN'T GOTTEN BACK TO YOU:
https://www.numpy.org/devdocs/dev/development_workflow.html#getting-your-pr-reviewed
-->