MAINT: Kill all instances of f2py.compile#25193
Conversation
mattip
left a comment
There was a problem hiding this comment.
LGTM. One small nit about the release note, and a question about using environment variables.
| The ``f2py.compile()`` helper has been removed due to a severe restriction in | ||
| functionality after the ``meson`` switch. Users are urged to replace these calls | ||
| with ``subprocess.run`` calls to ``python -m numpy.f2py`` instead with | ||
| environment variables set to interact with ``meson``. |
There was a problem hiding this comment.
Hmm. The use of environment variables is problematic. Isn't there any other way to hook into meson?
|
The |
rgommers
left a comment
There was a problem hiding this comment.
This LGTM, after a small rephrase of the release note and resolving the merge conflicts, I think this can go in.
MAINT: Fix typo DOC: Add a note on native files DOC: Update changelog Co-authored-by: Matti Picus <matti.picus@gmail.com> DOC: Update release note Co-authored-by: rgommers <rgommers@users.noreply.github.com>
a87f023 to
764c64e
Compare
rgommers
left a comment
There was a problem hiding this comment.
LGTM now, in it goes. Thanks Rohit!
Closes #25122 with my favored resolution. There was no dissent on the mailing list either. I'm happy to have this float around until
2.0.0(hence theversionchangedin the docs) but it should go, sooner perhaps rather than later.