BUG: Fix FP overflow error in division when the divisor is scalar#25191
Merged
charris merged 2 commits intonumpy:maintenance/1.26.xfrom Nov 19, 2023
Merged
BUG: Fix FP overflow error in division when the divisor is scalar#25191charris merged 2 commits intonumpy:maintenance/1.26.xfrom
charris merged 2 commits intonumpy:maintenance/1.26.xfrom
Conversation
The bug occurred when SIMD partial load was involved, due to filling remaining lanes of the dividend vector with ones, which leads to raised overflow warnings when the divisor is denormal. This patch replaces the remaining lanes with nans rather than ones to fix this issue.
The decision is based on the lack of native SIMD support for this operation in the armhf architecture, and the associated challenges in performance and evaluate the benefits of emulated SIMD intrinsic versus native scalar division.
21d3449 to
c6e29c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #25129.
The bug occurred when SIMD partial load was involved,
due to filling remaining lanes of the dividend vector
with ones, which leads to raised overflow warnings
when the divisor is denormal.
This patch replaces the remaining lanes with nans rather
than ones to fix this issue.
closes #25097