API: Make encoding=None the default in loadtxt#25158
Merged
charris merged 3 commits intonumpy:mainfrom Nov 16, 2023
Merged
Conversation
This has been a very long wart that `encoding=bytes` was always the default, which means that custom converters get bytes passed which is rather tedious. Now, changing this of course breaks some custom converters (luckily Python allow some simple things like `float()` for byte strings also. There is an odd deprecationwarning, but for now most (not all) test failures are fixed by passing `encoding="bytes"` explicitly.
Since I noticed them in the text loading docs (removes all though)
Member
|
Thanks Sebastian, let's see how it plays. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been a very long wart that
encoding=byteswas always the default, which means that custom converters get bytes passed which is rather tedious.Now, changing this of course breaks some custom converters (luckily Python allow some simple things like
float()for byte strings also.There is an odd deprecationwarning, but for now most (not all) test failures are fixed by passing
encoding="bytes"explicitly.This one is for @rossbar to review and make a decision on.