MAINT: Make numpy.linalg.linalg private#24946
Conversation
8539e2a to
27eda19
Compare
|
Hmm, maybe these named tuples should be public outside the typing? I have no idea if that's useful. In any case it's outside the scope of this PR. I agree, don't see any uses of any these namedtuple types outside of numpy itself, so I'm not worried about not having them publicly available. It seems there's some usage of these namedtuples in the array API compat layer - they're copy/pasted from numpy and it looks like Other than that this looks good to me. |
27eda19 to
58999ea
Compare
|
Let's bring this in, the question about making the |
|
Thanks for this PR!
No, I don't think that that is useful - I'd consider it namespace pollution without much of an upside. |
Hi @rgommers @ngoldbaum,
I started working on post-core-rename items to finalize NEP 52 (one thing is making sure with a test that each function is available from one place only).
In this PR I make
numpy.linalg.linalgprivate - I think that all linalg functionality should be accessed fromnumpy.linalgas its__init__.pydoesfrom .linalg import *.The only members of the submodule in question that aren't exported, and don't look private are:
But these are only return named tuples, rarely used, according to github search.