MAINT: Make numpy.fft.helper private#24945
Merged
ngoldbaum merged 2 commits intonumpy:mainfrom Oct 19, 2023
Merged
Conversation
e85ab5a to
35c8d7e
Compare
ngoldbaum
approved these changes
Oct 18, 2023
Member
ngoldbaum
left a comment
There was a problem hiding this comment.
Just one super minor comment, other than that this looks good to me.
|
|
||
| from .arrayterator import Arrayterator | ||
| from ._version import * | ||
| from .introspect import * |
Member
There was a problem hiding this comment.
I just double-checked, there's no need to modify __getattr__ below since np.lib.opt_func_info hasn't made it into a release yet.
numpy/fft/__init__.py
Outdated
|
|
||
| from . import _pocketfft, helper | ||
| from . import _pocketfft, _helper | ||
| from . import helper # TODO: to be deleted once people move to `np.fft` |
Member
There was a problem hiding this comment.
This comment should say it's deprecated in Numpy 2.0, following similar comments in the codebase so it's greppable.
Member
Author
There was a problem hiding this comment.
Sure! I updated the comment.
35c8d7e to
81c0c8b
Compare
bebfb1d to
19941fa
Compare
Member
|
Thanks @mtsokol! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @rgommers @ngoldbaum,
I started working on post-core-rename items to finalize NEP 52 (one thing is making sure with a test that each function is available from one place only).
In this PR I make
numpy.fft.helperprivate (nownumpy.fft._helper) as it defines four public functions that are already available fromnumpy.fft.I think that
helperis used a bit, therefore I left a stub that raises a warning on access. If you would like a more strict approach here (only anAttributeError) let me know!