Merged
Conversation
Member
|
Thanks @mtsokol! Looks like we had some tests that exercised |
Member
Author
|
That's right - fixing them now. |
9829f0f to
cdc8c81
Compare
cdc8c81 to
0666e33
Compare
rgommers
approved these changes
Oct 4, 2023
Member
rgommers
left a comment
There was a problem hiding this comment.
This looks happy now, the one CI failure is unrelated. All LGTM, and this was already discussed on the previous PR - so in it goes. Thanks Mateusz
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @rgommers,
In this PR I removed
np.dtype("a")alias that is the same asnp.dtype(bytes). I found only 10 legacy usages in the GitHub search, would you like to have a migration message here also?