ENH: add parameter strict to assert_allclose#24680
Conversation
mdhaber
left a comment
There was a problem hiding this comment.
To fix the CircleCI failure.
|
IIUC, I should add a file ? I'll also commit the |
|
That seems about right, yes. |
[skip actions] [skip cirrus] [skip azp]
There was a problem hiding this comment.
Two minor tweaks for the reviewer to consider. Feel free to commit.
When this looks good, I'll submit a follow-up for assert_equal, if that would be helpful?
These will help address #24667 (comment).
|
@mdhaber Please go ahead and commit your self-review changes so we can get this in. |
[skip actions] [skip cirrus] [skip azp]
|
Thanks @mattip. That rendered as intended. |
|
Thanks @mdhaber. Yes, I think |
This PR adds the parameter
stricttonp.testing.assert_allclose. Withstrict=True, the shape and dtype of the two arguments must match for the assertion to pass.Follows the example of gh-21595
Partially addresses suggestion in #24667 (comment)