Skip to content

DEP: Finalize fastCopyAndTranpose and other old C-funcs/members deprecations #24312

Merged
charris merged 4 commits intonumpy:mainfrom
seberg:finalize-c
Aug 3, 2023
Merged

DEP: Finalize fastCopyAndTranpose and other old C-funcs/members deprecations #24312
charris merged 4 commits intonumpy:mainfrom
seberg:finalize-c

Conversation

@seberg
Copy link
Member

@seberg seberg commented Aug 1, 2023

This removes fastCopyAndTranpose and the C:

  • PyArray_CopyAndTranspose
  • PyArray_ScalarFromObject
  • fastputmask
  • fasttake
  • fastclip

All of which have long been deprecated.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the removals, though I'm less familiar with the explicit process for doing so in C so someone else should doublecheck that. Otherwise LGTM, thanks @seberg !

@charris charris merged commit 4237991 into numpy:main Aug 3, 2023
@charris
Copy link
Member

charris commented Aug 3, 2023

Thanks Sebastian.

@seberg seberg deleted the finalize-c branch August 3, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants