API: Remove The MapIter API from public#24274
Closed
seberg wants to merge 3 commits intonumpy:mainfrom
Closed
Conversation
This API is very slow to use compared to normal advanced indexing (which reaches deep into the much richer internals). Making this fast is difficult and the only known users is Theano: * While probably still in use Theano is end-of-life for a long time. * The use-case in Theano would be better served with `ufunc.at` or direct advanced indexing use probably (even if that requires wrapping into NumPy arrays). Because it will be vastly faster normally. So remove it (make it private) to allow making the ABI of it not be a strange mix for backwards compatibility.
Member
|
While Theano per se is EOL, the codebase continues on as Aesara, which is the foundation for PyMC. Worth checking there. |
Member
Author
|
Ouch! Pinged them there. While I think that using Will close it for, I still want to stop using the slow API internally, but probably little point in breaking them just yet. |
Member
Author
|
Seems like Aesara is deprecating that code, so I might revive it after all: aesara-devs/aesara#1506 |
Member
Author
|
A major reason would be part of lifting the 32 maxargs/maxdims limit in the iterator, given the above, I think we should not let this hold the maxdims/maxarg lifting back. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This API is very slow to use compared to normal advanced indexing
(which reaches deep into the much richer internals).
Making this fast is difficult and the only known users is Theano:
ufunc.atordirect advanced indexing use probably (even if that requires
wrapping into NumPy arrays). Because it will be vastly faster
normally.
So remove it (make it private) to allow making the ABI of it not be
a strange mix for backwards compatibility.
It could also make sense to only make the struct almost fully opaque (with some macros to fetch the pointers needed in a version agnostic way). But considering that the only user is Theano, and that this is rather complicated...
Looking it partially, because I think we we need to improve
ufunc.at. At that point we won't use the "truly" public portion of the API anymore, ourselves.