API: Remove legacy-inner-loop-selector#24271
Merged
charris merged 1 commit intonumpy:mainfrom Jul 27, 2023
Merged
Conversation
441d65c to
823d5d9
Compare
seberg
commented
Jul 27, 2023
| *out_needs_api = 1; | ||
|
|
||
| return 0; | ||
| } |
Member
Author
There was a problem hiding this comment.
The default one works fine here. My guess is there was some historic reasons (maybe the needs api early on) of why it was explicit. Or just a micro-optimization, but if there is one loop to check that seems hardly necessary.
EDIT: Heureka: this must have pre-dated type-resolution. I.e. the loop selector was the promoter/type resolver. So this become unnecessary with the explicit type resolution step.
Remove legacy-inner-loop-selector and clean up the masked one (This was effectivly removed a while ago, but a deprecation was added for ABI compatibility if compiling against a newer NumPy that still had the slot). Removed the `reservedX` struct member docs, seems clear enough to not have them explicitly...
823d5d9 to
145065b
Compare
Member
|
Thanks Sebastian. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove legacy-inner-loop-selector and clean up the masked one (This was effectivly removed a while ago, but a deprecation was added for ABI compatibility if compiling against a newer NumPy that still had the slot).
Removed the
reservedXstruct member docs, seems clear enough to not have them explicitly...