BUG: Move legacy check for void printing#24270
Merged
mhvk merged 1 commit intonumpy:mainfrom Jul 27, 2023
Merged
Conversation
The check needs to be in the python path, because also the printing for `str()` subtly changed. To be the same as tuples, we should actually print `(np.float32(3.), np.int8(1))` for `str()` (tuples include the repr), while for `repr()` we include the dtype so we would print similar (but ideally with full precision) to arrays. This isn't quite ideal, I would be happy to print the full repr in the `str()` but I guess that might be a bit annoying in practice, so maybe our Numeric types are special enough for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check needs to be in the python path, because also the printing for
str()subtly changed.To be the same as tuples, we should actually print
(np.float32(3.), np.int8(1))forstr()(tuples include the repr), while forrepr()we include the dtype so we would print similar (but ideally with full precision) to arrays.This isn't quite ideal, I would be happy to print the full repr in the
str()but I guess that might be a bit annoying in practice, so maybe our Numeric types are special enough for now.@mhvk this should fix the remaining things in astropy. (As said above, no solution seems quite ideal, but it seemed more practical to stay with "numpy builtin types are special for
str(void).)