BUG: random: Fix check for both uniform variates being 0 in random_beta()#24204
Merged
charris merged 1 commit intonumpy:mainfrom Jul 18, 2023
Merged
BUG: random: Fix check for both uniform variates being 0 in random_beta()#24204charris merged 1 commit intonumpy:mainfrom
charris merged 1 commit intonumpy:mainfrom
Conversation
rkern
approved these changes
Jul 17, 2023
Member
rkern
left a comment
There was a problem hiding this comment.
Yes, from the comment and the subsequent check inside the if clause (which would be made irrelevant by the old version of the if test), I believe that is what was meant to be written.
Member
|
Thanks Warren. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check for both uniform variates being 0 was using
X + Y(which isU**(1/a) + V**(1/b)), instead ofU + V. Whenaandbare both sufficiently small, it will be common forX + Yto be 0.Closes gh-24203.