BUG: Only replace dtype temporarily if dimensions changed#24103
Merged
mattip merged 2 commits intonumpy:mainfrom Jul 5, 2023
Merged
BUG: Only replace dtype temporarily if dimensions changed#24103mattip merged 2 commits intonumpy:mainfrom
mattip merged 2 commits intonumpy:mainfrom
Conversation
For strings this is (currently) arguably not correct... Now of course strings shouldn't be changed to S0 probably, but that is a different matter. It seems there is something odd (possibly I just kept it as a corner case) for coercion from object arrays. Tests should cover the paths I think (lets see what CI says) but I couldn't reliably trigger failures for all paths. Closes numpygh-24043
Member
|
The pyiodide failure and 32 bit windows failures are real, it looks like. |
Member
|
Thanks @seberg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For strings this is (currently) arguably not correct... Now of course strings shouldn't be changed to S0 probably, but that is a different matter.
It seems there is something odd (possibly I just kept it as a corner case) for coercion from object arrays.
Tests should cover the paths I think (lets see what CI says) but I couldn't reliably trigger failures for all paths.
Closes gh-24043