BUG: Multiply or divides using SIMD without a full vector can cause divide-by-zero#24054
Merged
seberg merged 1 commit intonumpy:mainfrom Jun 27, 2023
Conversation
…ivide-by-zero The case occurs whenever a multiple or divide occurs (`array * scalar`) using SIMD and not a full vector can be used. The remaining lanes get zeroed, which can cause divide-by-zero or invalid to be raised. Xcode 14.3 includes an updated clang that supports FP Strict for arm64, which does not have any issues. Previous versions of Xcode / clang have incorrect codegen for this case.
Member
|
Oh, this is the identical pattern we already had further up, so lets just put it in, thanks LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23996
The case occurs whenever a multiply or divide occurs (
array * scalar) using SIMD and not a full vector can be used. The remaining lanes get zeroed, which can cause divide-by-zero or invalid to be raised.Xcode 14.3 includes an updated clang that supports FP Strict for arm64, which does not have any issues.
Previous versions of Xcode / clang have incorrect codegen for this case.