BUG: Ensure __array_ufunc__ works without any kwargs passed#24031
Merged
seberg merged 1 commit intonumpy:mainfrom Jun 24, 2023
Merged
BUG: Ensure __array_ufunc__ works without any kwargs passed#24031seberg merged 1 commit intonumpy:mainfrom
__array_ufunc__ works without any kwargs passed#24031seberg merged 1 commit intonumpy:mainfrom
Conversation
This doesn't happen in practice unless the function is manually called, and even then probably never because users should be passing `**kwargs` ensuring there is a dict passed...
mhvk
approved these changes
Jun 23, 2023
Contributor
mhvk
left a comment
There was a problem hiding this comment.
Looks good! I guess this was introduced in the change to fast call?
Member
Author
|
Didn't check, might also have always been there. |
Contributor
|
The failure isn't there on 1.24.2, so it must be something recent. Anyway, in the end I guess it doesn't matter, this fix looks right. |
Member
Author
|
Ah, if it's a regression it must have been part of adding |
__array_ufunc__ works without any kwargs passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't happen in practice unless the function is manually called, and even then probably never because users should be passing
**kwargsensuring there is a dict passed...Closes gh-24023