API: Remove old_defines.h (part of NumPy 1.7 deprecated C-API)#24011
Merged
charris merged 1 commit intonumpy:mainfrom Jun 21, 2023
Merged
API: Remove old_defines.h (part of NumPy 1.7 deprecated C-API)#24011charris merged 1 commit intonumpy:mainfrom
old_defines.h (part of NumPy 1.7 deprecated C-API)#24011charris merged 1 commit intonumpy:mainfrom
Conversation
d79c9ac to
b0371e3
Compare
b0371e3 to
611b36f
Compare
Member
|
Let's give this a shot. Do you know if Cython 3 is more compatible? |
Member
Author
|
We could just keep the aliases in Cython, but probably just have to force users to deal with it... Cython 3 will help a lot (or rather be required) if we want to e.g. hide the layout of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple removal. There is more in the 1.7 deprecated API, but this should be the easiest first step.
(We can probably remove all of the macros in the 1.7 api header. The main annoyance is that the cython exposes some of the macro names in it; not from this part of the API though. E.g.
numpy.randomdoes use those macros)