MAINT: removing the deprecated submodule#23809
Merged
seberg merged 3 commits intonumpy:mainfrom May 29, 2023
Merged
Conversation
seberg
approved these changes
May 28, 2023
Member
seberg
left a comment
There was a problem hiding this comment.
Thanks, LGTM either way. I had misunderstood that we even had a python stub without the underscore...
Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
Member
Author
The beauty of collecting all docstrings for testing 🙂 |
Member
Author
|
Does this need a mention in the release docs? I wasn't sure how pedantic it should be. |
Member
|
Oh, forgot, could add a bullet point into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functionality has been made private a while ago, and it's probably time to remove the submodule.