Skip to content

BLD: use the C++ linker to link _multiarray_umath.so#23601

Merged
charris merged 1 commit intonumpy:mainfrom
rgommers:cpp-linker
Apr 16, 2023
Merged

BLD: use the C++ linker to link _multiarray_umath.so#23601
charris merged 1 commit intonumpy:mainfrom
rgommers:cpp-linker

Conversation

@rgommers
Copy link
Copy Markdown
Member

@rgommers rgommers commented Apr 16, 2023

This gets rid of undefined symbol issues for assert.

Closes gh-23122
Closes gh-23595 EDIT: apparently not, something else is wrong there.

This gets rid of undefined symbol issues for `assert`.

Closes numpygh-23122
Closes numpygh-23595
@charris
Copy link
Copy Markdown
Member

charris commented Apr 16, 2023

Let's see if this works. Thanks Ralf.

@charris
Copy link
Copy Markdown
Member

charris commented Apr 16, 2023

Didn't work, same error. I think it is in the right direction, but not complete in itself. I wonder if we are running into the "hidden" problem.

@rgommers rgommers deleted the cpp-linker branch April 17, 2023 09:03
@rgommers rgommers added this to the 1.25.0 release milestone Apr 17, 2023
@rgommers
Copy link
Copy Markdown
Member Author

Build system wise this should be okay; and it did fix gh-23122. There's probably something specific in the code related to gh-23595 - let's continue dealing with that on that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants