Skip to content

CI: Add CI to test using gcc-12 on Intel Sapphire Rapids#23502

Merged
mattip merged 6 commits into
numpy:mainfrom
r-devulap:ci-spr
Apr 5, 2023
Merged

CI: Add CI to test using gcc-12 on Intel Sapphire Rapids#23502
mattip merged 6 commits into
numpy:mainfrom
r-devulap:ci-spr

Conversation

@r-devulap

Copy link
Copy Markdown
Member

Add CI to test AVX512FP16 content on Intel SPR (ex: PR #23435 and #23351).

@r-devulap

Copy link
Copy Markdown
Member Author

hmm, SDE SPR build taking forever.

@r-devulap

Copy link
Copy Markdown
Member Author

Ah, I should build outside the SDE and only run the tests in it. Fixing it.

Comment thread .github/workflows/build_test.yml Outdated
@r-devulap

Copy link
Copy Markdown
Member Author

Anyidea why this command fails with an error? Unable to run individual tests with the -n option.

python runtests.py -n -t numpy/core/tests/test_umath.py
no tests ran in 0.47s
ERROR: module or package not found: numpy/core/tests/test_umath.py (missing __init__.py?)

@mattip

mattip commented Apr 1, 2023

Copy link
Copy Markdown
Member

Maybe try the equivalent python runtests.py -n -- numpy/core/tests/test_umath.py?

@mattip

mattip commented Apr 4, 2023

Copy link
Copy Markdown
Member

The tests now run in 22 minutes, which seems acceptable. I wouldn't expect tests to fail here, is there a problem with the emulation?

One style nit: I prefer python -m pytest instead of bare pytest, but feel free to ignore it if you want.

@r-devulap

Copy link
Copy Markdown
Member Author

The tests now run in 22 minutes, which seems acceptable. I wouldn't expect tests to fail here, is there a problem with the emulation?

It doesn't fail locally. I also don't see these errors: AssertionError: FPU precision mode changed from 0x37f to 0x77f during the test. I am using SDE version 9.14, wonder if 9.7 has any issues. Lets try with latest version.

One style nit: I prefer python -m pytest instead of bare pytest, but feel free to ignore it if you want.

That's fine with me. I will fix it.

@r-devulap

Copy link
Copy Markdown
Member Author

Looks like v9.14 fixed it.

@mattip mattip merged commit c16a05c into numpy:main Apr 5, 2023
@mattip

mattip commented Apr 5, 2023

Copy link
Copy Markdown
Member

Thanks @r-devulap

@seiko2plus

Copy link
Copy Markdown
Member

Would it be better to combine it with sde_simd_avx512_test instead of having two actions?

@mattip

mattip commented Apr 5, 2023

Copy link
Copy Markdown
Member

I think we need two since we want to make sure both compilers (gcc12 and the default gcc in the manylinux image) pass tests

@seiko2plus

Copy link
Copy Markdown
Member

Make sense, sorry for the noise. I just thought sde_simd_avx512_test uses the default compiler of ubuntu-latest.

@mattip

mattip commented Apr 5, 2023

Copy link
Copy Markdown
Member

I just thought sde_simd_avx512_test uses the default compiler of ubuntu-latest

Hmm. Maybe it does and we should be forcing it to use 9.3? In any case, the default gcc in ubuntu 22.04 is 11.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants