BUG: fix loading and storing big arrays on s390x#23495
Merged
charris merged 1 commit intonumpy:mainfrom Apr 5, 2023
Merged
Conversation
505203d to
626a104
Compare
Member
|
I assume this is 390 specific? @seiko2plus Thoughts? |
Contributor
Author
|
As far as I'm aware it's s390x-specific. |
seiko2plus
approved these changes
Apr 5, 2023
Member
seiko2plus
left a comment
There was a problem hiding this comment.
LGTM, Thank you for the fix.
Member
|
Thanks @AlekseiNikiforovIBM . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix loading and storing big arrays on s390x and add testcase.
Due to cutting 32-bit int to 16-bit int, zeroes appear in the middle of big array.