BUG: Fix bug in parsing F77 style string arrays.#23470
Merged
charris merged 1 commit intonumpy:mainfrom Apr 21, 2023
Merged
Conversation
Example problematic variable: CHARACTER WORDARR(3)*8 This would be wrapped by an array with shape (3, 8) and dtype |S1, instead of the desired shape (3,) and dtype |S8. See numpy#23356.
Member
HaoZeke
reviewed
Apr 17, 2023
Member
HaoZeke
left a comment
There was a problem hiding this comment.
I think this should be good to go in as is, since it doesn't seem to break anything. The current behavior makes sense in some respect, keeping everything S1 is simpler, though it is a breaking change from #19388 as discussed in the issue. @pearu would be the best person for this.
That being said, the change seems harmless enough and respects BC (compatible with 1.23) so perhaps we should go ahead and see if other issues crop up. If not, a backport would be nice too.
Member
|
Thanks @bobeldering . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example problematic variable: CHARACTER WORDARR(3)*8
This would be wrapped by an array with shape
(3, 8)and dtype|S1, instead of the desired shape(3,)and dtype|S8.See #23356.