TYP: Add type annotations for comparison operators to MaskedArray.#23328
Merged
BvB93 merged 1 commit intonumpy:mainfrom Mar 5, 2023
Merged
TYP: Add type annotations for comparison operators to MaskedArray.#23328BvB93 merged 1 commit intonumpy:mainfrom
BvB93 merged 1 commit intonumpy:mainfrom
Conversation
The comparison operators seem to be missing annotations; whereas pretty much every other operator is annotated. This causes pytype to conclude that the output of, say, __gt__ is a regular ndarray, which isn't true.
BvB93
approved these changes
Mar 5, 2023
Member
BvB93
left a comment
There was a problem hiding this comment.
LGTM, this is one of those issues that would could have avoided in the first place by not hard-coding the ndarray output type in the superclass, buuuut good luck with that without higher ordered typevars...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comparison operators seem to be missing annotations; whereas pretty much every other operator is annotated.
This causes pytype to conclude that the output of, say,
__gt__is a regular ndarray, which isn't true.