TYP: Mark d argument to fftfreq and rfftfreq as optional in type stubs#23327
Merged
BvB93 merged 1 commit intonumpy:mainfrom Mar 5, 2023
Merged
TYP: Mark d argument to fftfreq and rfftfreq as optional in type stubs#23327BvB93 merged 1 commit intonumpy:mainfrom
d argument to fftfreq and rfftfreq as optional in type stubs#23327BvB93 merged 1 commit intonumpy:mainfrom
Conversation
The type stubs incorrectly mark this argument as mandatory.
d argument to fftfreq and rfftfreq as optional in type stubsd argument to fftfreq and rfftfreq as optional in type stubs
Member
|
Yup, good catch! Thanks @hawkinsp |
d argument to fftfreq and rfftfreq as optional in type stubsd argument to fftfreq and rfftfreq as optional in type stubs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type stubs incorrectly mark this argument as mandatory. It has a default argument, per the docs: https://numpy.org/doc/stable/reference/generated/numpy.fft.fftfreq.html
https://numpy.org/doc/stable/reference/generated/numpy.fft.rfftfreq.html