TYP: Replace duplicate reduce in ufunc type signature with reduceat.#23325
Merged
BvB93 merged 1 commit intonumpy:mainfrom Mar 5, 2023
Merged
TYP: Replace duplicate reduce in ufunc type signature with reduceat.#23325BvB93 merged 1 commit intonumpy:mainfrom
BvB93 merged 1 commit intonumpy:mainfrom
Conversation
Presumably this is a typo: ufuncs have both reduce and reduceat.
Member
|
LGTM, and in principle all the recent small fixes of false-positives can (potentially) be backported as far as I'm concerned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reduceappears twice. Presumably this is a typo: ufuncs have bothreduceandreduceat. This makes pytype unhappy with this pyi file.This change may make sense to backport.