ENH: Modify np.logspace so that the base argument broadcasts against start and stop#23275
Conversation
c1aa7c7 to
287c2e5
Compare
|
@seberg, would you mind bringing this to the attention of the appropriate reviewer? |
mhvk
left a comment
There was a problem hiding this comment.
I guess not something people have thought of, but really no reason not to make it work. Would need to update the docstring (at least the axis part). Perhaps also give an example?
|
p.s. I don't think I'd count this as a bug, but more like an enhancement. |
|
Ok sounds good. I thought it was a bug since the documentation said that |
4e6b8f5 to
f90e798
Compare
numpy.logspace so that the base argument broadcasts correctly against start and stopnumpy.logspace so that the base argument broadcasts correctly against start and stop
|
Do you have a reasoning for where to put the |
|
@seberg, the way I imagined it was that |
|
Sorry more coffee was needed, it is very obvious that broadcasting is fine. And I guess the old behavior was useless enough that it should be OK to change unceremoniously (i.e. it was mostly useless). |
|
Ah yes, more coffee is almost always needed! I'll add those changes straight away. |
f90e798 to
98d3beb
Compare
|
Quick :). Changes look good, thanks. But one more ask: I am suspecting you also want (and we should) add |
98d3beb to
8c6d312
Compare
|
Ah yes, you're absolutely right. I did not know that we needed to do that, good catch! |
…orrectly against `start` and `stop`.
8c6d312 to
3b89f52
Compare
numpy.logspace so that the base argument broadcasts correctly against start and stopnp.logspace so that the base argument broadcasts against start and stop
|
Thanks @byrdie. |
May close #23274