BUG: Use _Alignof to compute alignment.#23008
Closed
hawkinsp wants to merge 1 commit intonumpy:mainfrom
Closed
Conversation
It is undefined behavior to have a type declaration inside offsetof, see: llvm/llvm-project@e327b52 This code will fail to compile under upcoming versions of clang. If we have a C11-compliant compiler, use `_Alignof` instead.
Contributor
Author
|
I think the check failures are unrelated. This PR might be a candidate for backporting, also. |
Contributor
Author
|
Closing in favor of #23016 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is undefined behavior to have a type declaration inside
offsetof, see:llvm/llvm-project@e327b52
This code will fail to compile under upcoming versions of clang.
If we have a C11-compliant compiler, use
_Alignofinstead.