BUG: Ensure correct loop order in sin, cos, and arctan2#22986
Merged
charris merged 1 commit intonumpy:mainfrom Jan 10, 2023
Merged
BUG: Ensure correct loop order in sin, cos, and arctan2#22986charris merged 1 commit intonumpy:mainfrom
charris merged 1 commit intonumpy:mainfrom
Conversation
These were incorrect afer being vectorized. The commit additional tests these (not arctan2 admittedly) and adds a check to generate_umath to make it a bit less likely that future additions add this type of thing. Note that the check allows duplicated loops so long they are correctly ordered the *first* time. This makes results correct, but duplicated loops are not nice anyways and it would be nice to remove them. We could drop them manually in hindsight even? In any case, that should not be backported, so it is not includedhere. Closes numpygh-22984
seberg
commented
Jan 10, 2023
| TD('f', dispatch=[('loops_trigonometric', 'f')]), | ||
| TD('ed', dispatch=[('loops_umath_fp', 'ed')]), | ||
| TD('fdg' + cmplx, f='cos'), | ||
| TD('d', dispatch=[('loops_umath_fp', 'd')]), |
Member
Author
There was a problem hiding this comment.
These can be written a single line, but since that is not used anywhere, decided not to...
Member
|
Thanks Sebastian. Does this need a backport? |
Member
Author
|
Yes, sorry, forgot to tag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were incorrect afer being vectorized. The commit additional tests these (not arctan2 admittedly) and adds a check to generate_umath to make it a bit less likely that future additions add this type of thing.
Note that the check allows duplicated loops so long they are correctly ordered the first time. This makes results correct, but duplicated loops are not nice anyways and it would be nice to remove them.
We could drop them manually in hindsight even? In any case, that should not be backported, so it is not includedhere.
Closes gh-22984