BUG, SIMD: Fix spurious invalid exception for sin/cos on arm64/clang#22954
Merged
seberg merged 1 commit intonumpy:mainfrom Jan 6, 2023
Merged
BUG, SIMD: Fix spurious invalid exception for sin/cos on arm64/clang#22954seberg merged 1 commit intonumpy:mainfrom
seberg merged 1 commit intonumpy:mainfrom
Conversation
seberg
approved these changes
Jan 6, 2023
Member
seberg
left a comment
There was a problem hiding this comment.
Having to do asm is annoying, but notnan really must not set these flags.
Confirmed that this fixes the tests on my M1, thanks!
Member
Author
I couldn't find another way |
Member
|
Yeah I trust that that this is a good way; that was meant as a compliment :). Thanks again, lets put it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #22933