TST: Add fixture to avoid issue with randomizing test order.#22931
Merged
seberg merged 1 commit intonumpy:mainfrom Jan 5, 2023
Merged
TST: Add fixture to avoid issue with randomizing test order.#22931seberg merged 1 commit intonumpy:mainfrom
seberg merged 1 commit intonumpy:mainfrom
Conversation
Member
|
Makes sense as a work-around. Will we remember to remove it when a fix for #22825 is found? |
Member
|
Thanks. If we want to fix it, probably should go full way and create a context var and manager? Overall, I doubt its high priority, since the main point of this is to have different defaults in various terminals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a missing test fixture to prevent cross-talk between polynomial printing test classes when the test order is randomized with
pytest-randomly.Addresses the immediate issue #22825 though there is another, deeper issue with polynomial printing thread safety. Therefore #22825 should either be left open or a follow-up issue opened.