Skip to content

MAINT: Remove two TODO notes that got outdated#22788

Merged
rossbar merged 1 commit intonumpy:mainfrom
seberg:remove-todo
Dec 13, 2022
Merged

MAINT: Remove two TODO notes that got outdated#22788
rossbar merged 1 commit intonumpy:mainfrom
seberg:remove-todo

Conversation

@seberg
Copy link
Copy Markdown
Member

@seberg seberg commented Dec 13, 2022

The first one should have been removed in gh-22735, the second an even more random find.

The first one should have been removed in numpygh-22735, the second an even more
random find.
@seberg
Copy link
Copy Markdown
Member Author

seberg commented Dec 13, 2022

Weird, circlci is failing right now with:

fatal: couldn't find remote ref refs/pull/22788/head

For now, I guess I will hope this is just a transient issue?

Copy link
Copy Markdown
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seberg - I agree about the circleci hiccup, definitely unrelated. Let's see if it resolves itself in future PRs

@rossbar rossbar merged commit 3139a88 into numpy:main Dec 13, 2022
@seberg seberg deleted the remove-todo branch December 13, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants