API: (cython) remove long_t and ulong_t#22637
Merged
rgommers merged 1 commit intonumpy:mainfrom Nov 28, 2022
Merged
Conversation
They are both very confusing aliases. Unfortunately, I did not find a way to give a more informative cython compilation error. Thus, I pasted the expected error message in the hope it will be easy to google. The release notes are long and maybe confusing. I really want to prepare us for switching the default integer to (probably) `intp` and this could be rather disprutpive for Cython modules if, so I thought it might be good to hint towards that, but maybe that is too much?
e9ff83c to
5f0f1e6
Compare
rgommers
approved these changes
Nov 22, 2022
Member
rgommers
left a comment
There was a problem hiding this comment.
I think this is a good idea. Just in case something important breaks, we can revert it for a bit to give others the change to patch things up.
Member
Author
|
Yeah, I think its just time to give it a shot. It is super niche, won't even break compiled extensions and is easy to fix. |
Member
|
🤞🏼 in it goes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are both very confusing aliases. Unfortunately, I did not find a way to give a more informative cython compilation error. Thus, I pasted the expected error message in the hope it will be easy to google.
The release notes are long and maybe confusing. I really want to prepare us for switching the default integer to (probably)
intpand this could be rather disprutpive for Cython modules if, so I thought it might be good to hint towards that, but maybe that is too much?