Skip to content

TYP: Update type annotations for new 1.24 features#22587

Merged
charris merged 5 commits intonumpy:mainfrom
BvB93:typing
Nov 15, 2022
Merged

TYP: Update type annotations for new 1.24 features#22587
charris merged 5 commits intonumpy:mainfrom
BvB93:typing

Conversation

@BvB93
Copy link
Copy Markdown
Member

@BvB93 BvB93 commented Nov 14, 2022

Xref #21753

Adds, removes and/or modifies the type annotations of features newly added in the numpy 1.24 dev cycle.
See the individual commits for more details.

@charris charris merged commit 8fff8ce into numpy:main Nov 15, 2022
@charris
Copy link
Copy Markdown
Member

charris commented Nov 15, 2022

Thanks Bas.

@BvB93 BvB93 deleted the typing branch November 15, 2022 18:43
@hawkinsp
Copy link
Copy Markdown
Contributor

hawkinsp commented Mar 3, 2023

This change makes pytype sad, because msort is still imported in numpy/__init__.pyi and numpy/lib/__init__.pyi but does not exist in numpy/lib/function_base.pyi, from where it is being imported.

Could we either (a) readd the msort annotation to function_base or (b) remove the imports of the now-deleted annotation? Which is preferable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants