MAINT: Rm meaningless checks in determining typeless data#22586
Merged
seberg merged 1 commit intonumpy:mainfrom Nov 14, 2022
Merged
MAINT: Rm meaningless checks in determining typeless data#22586seberg merged 1 commit intonumpy:mainfrom
seberg merged 1 commit intonumpy:mainfrom
Conversation
The issubclass should always be false in Python3, so this change should not change behavior.
Member
|
Going to put it in, thanks. But the check still had a purpose: hiding the |
Contributor
Author
IIUC, if np.longlong(1).itemsize == np.int_(1).itemsize:
_typelessdata.append(np.longlong)or have I misunderstood? |
Member
|
Int is long, so its either longlong or cint. Both paths that existed are necessary. One for windows (mainly) one for others (the longlong). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup some checks that were only relevant for Python2