BUG: Decrement ref count in gentype_reduce if allocated memory not used#22557
Merged
seberg merged 1 commit intonumpy:mainfrom Nov 9, 2022
Merged
BUG: Decrement ref count in gentype_reduce if allocated memory not used#22557seberg merged 1 commit intonumpy:mainfrom
seberg merged 1 commit intonumpy:mainfrom
Conversation
Contributor
Author
|
@seberg @ganesh-k13 Could you please review the pull request? Thank you. |
Member
|
Thanks, just had to have a close enough look with the refcounting glasses 🧮 👓 . Looks all good though, thanks @aayushagrawal135. |
Contributor
Author
|
Yay🎉 Thanks for taking a look and merging it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #21495
Done as part of PyData NYC 2022.