TST: Make test_partial_iteration_cleanup robust but require leak checker#22485
Merged
charris merged 1 commit intonumpy:mainfrom Oct 28, 2022
Merged
TST: Make test_partial_iteration_cleanup robust but require leak checker#22485charris merged 1 commit intonumpy:mainfrom
charris merged 1 commit intonumpy:mainfrom
Conversation
This makes sure the test is not flaky, but the test now requires a leak checker (both valgrind or reference count based should work in CPython at least). Closes numpygh-21169
Member
Author
|
Hmmm, the test failure (not cygwin, that just failed randomly) seems due to pytest phasing out some nose backcompat stuff. The main part seems to be |
Member
|
To be clear, the test runs but does not error, leak detection is left to valgrind etc. ? |
Member
Author
|
Yes, I guess the test still may cover some code path. But the main reason why its there is only checked when running with pytest-valgrind or pytest-leaks (or similar). |
Member
|
Thanks Sebastian. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure the test is not flaky, but the test now requires a leak checker (both valgrind or reference count based should work in CPython at least).
Closes gh-21169