MAINT: Ensure that fmin loops do not show up multiple times#22466
Merged
charris merged 1 commit intonumpy:mainfrom Oct 23, 2022
Merged
MAINT: Ensure that fmin loops do not show up multiple times#22466charris merged 1 commit intonumpy:mainfrom
charris merged 1 commit intonumpy:mainfrom
Conversation
This is not problematic for NumPy, because fmin/fmax have a custom type resolver, however, Numba relies on the order (they should not ideally, but probably have little choice currently). Even without Numba, having the multiple loops is not nice though. Closes numpygh-22376
Member
|
Should we add a test that no ufunc has a repeated left side of |
Member
|
Thanks Sebastian.
We might want to make a careful review at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not problematic for NumPy, because fmin/fmax have a custom type resolver, however, Numba relies on the order (they should not ideally, but probably have little choice currently). Even without Numba, having the multiple loops is not nice though.
Closes gh-22376