MAINT: Ensure graceful handling of large header sizes#22393
Merged
mattip merged 1 commit intonumpy:mainfrom Oct 6, 2022
Merged
MAINT: Ensure graceful handling of large header sizes#22393mattip merged 1 commit intonumpy:mainfrom
mattip merged 1 commit intonumpy:mainfrom
Conversation
mattip
reviewed
Oct 6, 2022
mattip
reviewed
Oct 6, 2022
ad1d46a to
635706c
Compare
mattip
approved these changes
Oct 6, 2022
Member
mattip
left a comment
There was a problem hiding this comment.
LGTM. Maybe open_memmap could get a kwarg-only *, but not critical.
This ensures graceful handling of large header files. Unfortunately, it may be a bit inconvenient for users, thus the new kwarg and the work-around of also accepting allow-pickle. See also the documation here: https://docs.python.org/3.10/library/ast.html#ast.literal_eval
Member
|
Thanks @seberg. Is this going to be backported? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures graceful handling of large header files. Unfortunately, it may be a bit inconvenient for users, thus the new kwarg and the work-around of also accepting allow-pickle.
See also the documation here:
https://docs.python.org/3.10/library/ast.html#ast.literal_eval