DOC: Update delimiter param description.#22372
Merged
seberg merged 2 commits intonumpy:mainfrom Oct 5, 2022
Merged
Conversation
Explicitly state that only single-character delimiters are supported.
Member
|
Yeah, I don't have a a real preference, but maybe it is good to be clear about the change. We also disallowed |
Member
|
Thanks, Ross. |
Contributor
Author
|
@charris I've added the backport candidate label for this one even though it's a docs PR. The change went into effect in 1.23 so the notification of the change in the docs should in principle be backported as well. It's not critically important though - apologies if this is an abuse of the backport candidate label! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the description for the
delimiterparameter inloadtxtto note that only single-character strings are supported. In principle, this new info could be in a.. versionchanged:: 1.23directive - any preference there @seberg ?Closes #22311