BUG: Fix complex vector dot with more than NPY_CBLAS_CHUNK elements#22327
Merged
charris merged 1 commit intonumpy:mainfrom Sep 22, 2022
Merged
BUG: Fix complex vector dot with more than NPY_CBLAS_CHUNK elements#22327charris merged 1 commit intonumpy:mainfrom
charris merged 1 commit intonumpy:mainfrom
Conversation
The iteration was simply using the wrong value, the larger value might even work sometimes, but then we do another iteration counting the remaining elements twice. Closes numpygh-22262
charris
approved these changes
Sep 22, 2022
Member
|
Thanks Sebastian, I can confirm that this fixes things for me. |
Contributor
|
Nice fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iteration was simply using the wrong value, the larger value might even work sometimes, but then we do another iteration counting the remaining elements twice.
Closes gh-22262