MAINT,TYP: Add object-overloads for the np.generic rich comparisons#21984
Merged
mattip merged 1 commit intonumpy:mainfrom Jul 17, 2022
Merged
MAINT,TYP: Add object-overloads for the np.generic rich comparisons#21984mattip merged 1 commit intonumpy:mainfrom
np.generic rich comparisons#21984mattip merged 1 commit intonumpy:mainfrom
Conversation
Member
|
Thanks @BvB93 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21939
An overload was previously missing for object-based rich comparisons of the
np.genericsubclasses.As object array-likes are notoriously difficult to type, the new overload simply checks whether the right operand supports
__gt__or__lt__even though this will, in practice, be a bit too broad (e.g. it allowsnp.int64(1) > "test"to pass).