BUG: Fix KeyError in crackfortran operator support#21890
Merged
charris merged 1 commit intonumpy:mainfrom Jul 8, 2022
Merged
Conversation
Member
|
Makes sense, should there be a test? |
Member
Author
Perhaps, but also not much use at this stage since it isn't actually implemented in any meaningful way (and we don't test EDIT: @bnavigator isolated a test! Will update this ASAP. |
Member
|
Thanks @HaoZeke I'm going to put this in for the 1.23.1 release. Please make another PR to add the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21889 by simply using the safer
.get()variant which returnsNoneinstead of aKeyError. This in turn allows the rest of the check to pass due tonot Noneevaluating toTrueand keeping the rest of the intended logic.Note that there isn't actually any handling of
operator()or evenimplementedbyin the rest of F2PY yet (it was an enhancement done forsphinx-fortranI think).