Skip to content

DOC: style main page card#21456

Merged
rossbar merged 1 commit intonumpy:mainfrom
tupui:style_card
May 9, 2022
Merged

DOC: style main page card#21456
rossbar merged 1 commit intonumpy:mainfrom
tupui:style_card

Conversation

@tupui
Copy link
Copy Markdown
Contributor

@tupui tupui commented May 5, 2022

Update the CSS of the cards on the main page of the documentation. The current panel has very large images.

Left is current, right is this PR–same zoom level was used.

currnew

@tupui
Copy link
Copy Markdown
Contributor Author

tupui commented May 5, 2022

If it's preferred I can also go back to this padding. Note the gray area.

.intro-card {
  padding: 20px 0px 20px 0px;
  margin: 10px;
}

alt

[skip actions] [skip travis]
@seberg
Copy link
Copy Markdown
Member

seberg commented May 6, 2022

I don't have a strong opinion, maybe a slight tendency to restoring the no-border version. I feel that the current pictograms are oversized so I prefer the scaled down version (but don't care much how much we scale them down).

Ping @MarsBarLee again, IIRC, you took part in styling this? Do you have any opinions/preferences here?

Comment on lines +35 to +38
.intro-card {
padding: 20px 10px 20px 10px;
margin: 10px;
}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the no-border on the gray.

Suggested change
.intro-card {
padding: 20px 10px 20px 10px;
margin: 10px;
}
.intro-card {
padding: 20px 0px 20px 0px;
margin: 10px;
}

Copy link
Copy Markdown
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks @tupui !

This was discussed a bit at the docs meeting and the consensus was that this is an improvement

@rossbar rossbar merged commit 9d32cf7 into numpy:main May 9, 2022
@tupui
Copy link
Copy Markdown
Contributor Author

tupui commented May 9, 2022

Thanks Ross!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants